[bug 910884] [bug 910887] [bug 910886] Badges pages styled#1633
Closed
rehandalal wants to merge 13 commits intomozilla:masterfrom
rehandalal:style-badger
Closed
[bug 910884] [bug 910887] [bug 910886] Badges pages styled#1633rehandalal wants to merge 13 commits intomozilla:masterfrom rehandalal:style-badger
rehandalal wants to merge 13 commits intomozilla:masterfrom
rehandalal:style-badger
Conversation
Contributor
Author
|
@mythmon ideas about why Travis is unhappy? |
Contributor
|
can you attach screenshots to each bug and needs info Kadir? |
Contributor
Author
|
@rlr already done! |
Contributor
|
gah! my bad i havent opened bug mail yet 👍 |
Member
|
Regarding Travis, looks to me like iirc hasn't started. We've seen that happen a few times. I clicked on the restart button. |
Member
|
^^^ Travis passed. |
Contributor
Author
|
yay! |
Contributor
There was a problem hiding this comment.
Badge titles are localizable now, should do _(badge.title, 'DB: badger.Badge.title')
Contributor
|
hot! lots of minor comments mostly just gettext, datetimeformat and profile_url related. |
Contributor
|
one more thing: HI @mythmon ! |
Contributor
Author
|
all the things are fixored ^ 🐌 |
Contributor
|
love it, r+! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r?